Skip to content

show keybinding instead of 'menu-item' in embark-bindings #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dwa wants to merge 3 commits into
base: master
Choose a base branch
from
Open

show keybinding instead of 'menu-item' in embark-bindings #759

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
904827d
show keybinding instead of 'menu-item' in embark-bindings
Jun 3, 2025
a72b2f5
use recursion on menu-items
Jun 5, 2025
0d7eeb3
filter out the <keymap>:s, they are unusable here.
Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions embark.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1309,7 +1309,7 @@ first line of the documentation string; for keyboard macros use
(cond
((or (stringp cmd) (vectorp cmd)) (key-description cmd))
((stringp (car-safe cmd)) (car cmd))
((eq (car-safe cmd) 'menu-item) (eval (cadr cmd)))
((eq (car-safe cmd) 'menu-item) (embark--command-name (caddr cmd)))
((keymapp cmd)
(propertize (if (symbolp cmd) (format "+%s" cmd) "<keymap>")
'face 'embark-keymap))
Expand Down Expand Up @@ -1371,11 +1371,9 @@ If NESTED is non-nil subkeymaps are not flattened."
for cmd = (keymap--menu-item-binding def)
unless (memq cmd '(nil embark-keymap-help
negative-argument digit-argument))
unless (string= "<keymap>" name)
collect (list name cmd key
(concat
(if (eq (car-safe def) 'menu-item)
"menu-item"
(key-description key))))))
(concat (key-description key)))))
(width (cl-loop for (_name _cmd _key desc) in commands
maximize (length desc)))
(default)
Expand Down