python: support aarch64 #132
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnpnr
force-pushed
the
python-aarch64
branch
from
fe1e991 to
f52a524
Compare
| #define HAVE_GCC_ASM_FOR_X64 1 | ||
| #define HAVE_GCC_ASM_FOR_X87 1 | ||
| /* #undef HAVE_GCC_ASM_FOR_X64 */ | ||
| /* #undef HAVE_GCC_ASM_FOR_X87 */ |
Collaborator
There was a problem hiding this comment.
Maybe we could just guard this by
#if __x86_64__
...
#endif
Contributor
Author
There was a problem hiding this comment.
Yes, you could. One reason to keep it as I’ve written it is that if you update the header on an amd64 system and forget to include the #if __x86_64__ the compiler will warn you about redefining those macros
I could go either way though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.