feat(crystal): add optional plotting control and type annotations to calc_Darwin_curve#10
Open
HenriqueTortura wants to merge 4 commits intomasterfrom
Open
feat(crystal): add optional plotting control and type annotations to calc_Darwin_curve#10HenriqueTortura wants to merge 4 commits intomasterfrom
HenriqueTortura wants to merge 4 commits intomasterfrom
Conversation
Introduce a `plot_fig` boolean flag to allow disabling figure generation in calc_Darwin_curve. This prevents unnecessary plotting during batch executions and parameter sweeps, improving runtime performance and avoiding GUI blocking in non-interactive contexts. The default behavior is unchanged (plotting enabled), preserving backward compatibility.
Move plt.show() after optional plt.savefig() to ensure figures are properly written to disk before rendering or closing the figure. This prevents empty or incomplete image files when saving figures in non-interactive or batch execution environments.
HenriqueTortura
requested review from
HumbertoRigamonti,
gio-ribeiro and
jpastolfo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a plotting toggle and type annotations to
calc_Darwin_curve.Changes
plot_figargument to control figure generationplt.savefig()is executed beforeplt.show(), so figures are saved before being shownNotes
Possible follow-ups