[WIP] Migrating from x509-parser to x509-cert #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Yubico FIDO Root CA Serial 450203556 * Use Attestation Root instead of FIDO Root CA * Refactor * Make Tests Consistent When I was originally writing the Mozilla handler for this library, I didn't implement hashing of the challenge because there is no way to take in a challenge from a remote host. This is why @timweri had to remove the hashing from the test in his earlier commits. We now generate random data first, then hash it such that we can get the preimage to test it properly. This also will allow us to extend the API into the future to allow remote challenges for key generation verification. * Bump version * Add new PIV root CA and intermediates --------- Co-authored-by: Mitchell Grenier <mitchell@confurious.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: Doesn't build
All of these are untested. Just committing for visbility.
It seems like
x509-certdoesn't implement cert signature verification.