Enhance CSV import/export of tests and update error plotting#10
Open
pascalresch wants to merge 9 commits intomasterfrom
Open
Enhance CSV import/export of tests and update error plotting#10pascalresch wants to merge 9 commits intomasterfrom
pascalresch wants to merge 9 commits intomasterfrom
Conversation
obersteiner
reviewed
Feb 3, 2021
| "import csv\n", | ||
| "import matplotlib.pyplot as plt\n", | ||
| "\n", | ||
| "from PerformTestCase import PlotTestCase\n", |
Owner
There was a problem hiding this comment.
Passt nicht mit pip Installation zusammen. Verwende sparseSpACE.PerformTestCase. Außerdem fehlt import sparseSpACE
obersteiner
reviewed
Feb 3, 2021
sparseSpACE/PerformTestCase.py
Outdated
Comment on lines
339
to
340
| self.colormap = colormap | ||
| self.line_style_map = line_style_map |
Owner
There was a problem hiding this comment.
It would be nice to have default colormaps and linepaths. It is tedious to set them always manually. Maybe instead pass the algorithms and this constructor sets some default colours and line styles to them? Or always assign colors anew for each plot?
Owner
|
As far as I have seen the ipynb for the evaluations can not be executed without error as the corresponding output folders do not exist. So we could either create the folders for the evaluations if needed or add empty folders to the repository. I think we should opt for the first option. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.