Open
Conversation
gmaze
requested changes
Aug 17, 2020
Member
gmaze
left a comment
There was a problem hiding this comment.
@sdat2 , thanks for your contribution !
this new function seems to return an unravelled version of the preprocessed data, which in this specific PCM configuration, happens to be the stacked/joined PCA eigen values.
so, my comments:
- if users modified default options, the returned array may not corresponds to the PCA value (eg: if using another reduce function), so the vocab here would be wrong.
- the
pcadimension of the output array could be generalized as a "reduced_dimension", which is a reduced version of thedimpassed as argument. - I would rather return by default a dataset where the feature variables are back into separate dataArrays, instead of the stacked version here. At least this should be an option (and possibly takes into account the tentative future PCM option "join" discussed in #27 )
The request changes are thus a more general version of this function taking into account the 3 comments above.
Then the documentation could be updated to show users how to get access to PCA values using this new function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a PR just adding a method called
add_pca_to_xarrayto thepcmclass. The name and implementation could be improved, so please feel free to change whatever you would like to.