Fix: gracefully abort thread using sdk #2317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrongMonkey
requested review from
g-linville,
ibuildthecloud,
njhale,
thedadams and
tybalex
thedadams
reviewed
Mar 28, 2025
| if err := i.gptClient.AbortRun(ctx, run); err != nil { | ||
| return false, err | ||
| } | ||
| go timeoutAfter(ctx, cancel, 30*time.Second) |
Contributor
There was a problem hiding this comment.
Can we add a comment about why this is necessary?
Contributor
There was a problem hiding this comment.
I asked for the 30 second thing as a fail safe if the proper abort was to not work for some reason. And yeah add a comment about that.
Contributor
Author
There was a problem hiding this comment.
added a comment
thedadams
approved these changes
Mar 28, 2025
Signed-off-by: Daishan Peng <daishan@acorn.io>
g-linville
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gptscript-ai/gptscript#956
Using gptscript sdk to terminate thread and get proper message back. suggested by darren https://acorn-io.slack.com/archives/C07P0EZR917/p1743120573464899
#1982