Skip to content

let the pointer's pointerdown event propagate #2267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

let the pointer's pointerdown event propagate #2267

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3099083
ignore the same event if it's already been processed
Fil Jan 3, 2025
f7d059e
Merge branch 'main' into fil/pointer-suppression
Fil Feb 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/interactions/pointer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import {isArray} from "../options.js";
import {applyFrameAnchor} from "../style.js";

const states = new WeakMap();
const processedEvents = new WeakSet();

function pointerK(kx, ky, {x, y, px, py, maxRadius = 40, channels, render, ...options} = {}) {
maxRadius = +maxRadius;
Expand Down Expand Up @@ -162,12 +163,13 @@ function pointerK(kx, ky, {x, y, px, py, maxRadius = 40, channels, render, ...op
}

function pointerdown(event) {
if (processedEvents.has(event)) return; // ignore same event on a shared pointer
processedEvents.add(event);
if (event.pointerType !== "mouse") return;
if (i == null) return; // not pointing
if (state.sticky && state.roots.some((r) => r?.contains(event.target))) return; // stay sticky
if (state.sticky) (state.sticky = false), state.renders.forEach((r) => r(null)); // clear all pointers
else (state.sticky = true), render(i);
event.stopImmediatePropagation(); // suppress other pointers
}

function pointerleave(event) {
Expand Down