Conversation
|
For precision : test was done on ubuntu 24.04 |
|
Before we merge a fix for just a single issue, it would be great if we could get confirmation for a full test suite of possible URLs being confirmed to work as expected, otherwise we just pile little fixes on top of each other (and I repeat my suggestion made offline to use |
3519c81 to
c4597cd
Compare
PatTheMav
left a comment
There was a problem hiding this comment.
Doesn't break valid POSIX file paths anymore, but I haven't run a full gamut of checks for paths that are considered invalid by this.
RytoEX
left a comment
There was a problem hiding this comment.
Per off-thread discussion, going to merge this, but would like to see more comprehensive testing (a list of URLs tested and expected and actual outcomes).
c4597cd to
8c0dba8
Compare
|
On Windows 11, I tested the following supported scenarios (all should load and therefore PASS). Local File: URL: |
Description
Fixes the leading
/being trimmed on posix filesystems.Motivation and Context
Want local files to work.
How Has This Been Tested?
Tested by Penwywern on Discord.
Types of changes
Checklist: