frontend: Fix the UI color for estimated memory values#13177
Open
hre0 wants to merge 1 commit intoobsproject:masterfrom
Open
frontend: Fix the UI color for estimated memory values#13177hre0 wants to merge 1 commit intoobsproject:masterfrom
hre0 wants to merge 1 commit intoobsproject:masterfrom
Conversation
6c6a193 to
3d064a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added styling change to show white coloring for values under
memMaxMBfor the slotAdvReplayBufferChanged()inOBSBasicSettings.cpp.After:
Before:
Motivation and Context
This fixes the coloring of the text, which retains the previous coloring from an estimated memory value that exceeds the recommended maximum for replay time of the replay buffer (
memMB <= memMaxMB.).Although the text displays a warning message when the estimation exceeds the max, returning the text coloring to white for estimations under the max will eliminate possible confusion, with incorrect coloring being associated with acceptable estimations.
Resolves issue #13171
How Has This Been Tested?
Testing the changes locally on Windows 11.
Types of changes
Checklist: