Skip to content

frontend: Fix the UI color for estimated memory values#13177

Open
hre0 wants to merge 1 commit intoobsproject:masterfrom
hre0:frontend/incorrect-ui-color
Open

frontend: Fix the UI color for estimated memory values#13177
hre0 wants to merge 1 commit intoobsproject:masterfrom
hre0:frontend/incorrect-ui-color

Conversation

@hre0
Copy link

@hre0 hre0 commented Mar 2, 2026

Description

Added styling change to show white coloring for values under memMaxMB for the slot AdvReplayBufferChanged() in OBSBasicSettings.cpp.

After:

correct incorrect

Before:

image

Motivation and Context

This fixes the coloring of the text, which retains the previous coloring from an estimated memory value that exceeds the recommended maximum for replay time of the replay buffer (memMB <= memMaxMB.).

Although the text displays a warning message when the estimation exceeds the max, returning the text coloring to white for estimations under the max will eliminate possible confusion, with incorrect coloring being associated with acceptable estimations.

Resolves issue #13171

How Has This Been Tested?

Testing the changes locally on Windows 11.

Types of changes

  • Tweak (non-breaking change to improve existing functionality).

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@Fenrirthviti Fenrirthviti added Bug Fix Non-breaking change which fixes an issue UI/UX Anything to do with changes or additions to UI/UX elements. labels Mar 2, 2026
@hre0 hre0 changed the title frontend: corrected the UI color for estimated memory values frontend: Fix the UI color for estimated memory values Mar 3, 2026
@hre0 hre0 force-pushed the frontend/incorrect-ui-color branch from 6c6a193 to 3d064a1 Compare March 3, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Fix Non-breaking change which fixes an issue UI/UX Anything to do with changes or additions to UI/UX elements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replay buffer's estimated memory usage incorrect color restore

2 participants