RFC 45-5: Allow selection of the audio codec/encoder

UI/audio-encoders.cpp

@@ -23,18 +23,17 @@ static const char *EncoderName(const std::string &id)
 	return NullToEmpty(obs_encoder_get_display_name(id.c_str()));
 }
 
-static map<int, std::string> bitrateMap;
-
-static void HandleIntProperty(obs_property_t *prop, const char *id)
+static void HandleIntProperty(obs_property_t *prop, std::vector<int> &bitrates)
 {
 	const int max_ = obs_property_int_max(prop);
 	const int step = obs_property_int_step(prop);
 
 	for (int i = obs_property_int_min(prop); i <= max_; i += step)
-		bitrateMap[i] = id;
+		bitrates.push_back(i);
 }
 
-static void HandleListProperty(obs_property_t *prop, const char *id)
+static void HandleListProperty(obs_property_t *prop, const char *id,
+			       std::vector<int> &bitrates)
 {
 	obs_combo_format format = obs_property_list_format(prop);
 	if (format != OBS_COMBO_FORMAT_INT) {
@@ -53,7 +52,7 @@ static void HandleListProperty(obs_property_t *prop, const char *id)
 
 		int bitrate =
 			static_cast<int>(obs_property_list_item_int(prop, i));
-		bitrateMap[bitrate] = id;
+		bitrates.push_back(bitrate);
 	}
 }
 
@@ -86,7 +85,7 @@ static void HandleSampleRate(obs_property_t *prop, const char *id)
 	obs_property_modified(prop, data.get());
 }
 
-static void HandleEncoderProperties(const char *id)
+static void HandleEncoderProperties(const char *id, std::vector<int> &bitrates)
 {
 	auto DestroyProperties = [](obs_properties_t *props) {
 		obs_properties_destroy(props);
@@ -112,10 +111,10 @@ static void HandleEncoderProperties(const char *id)
 	obs_property_type type = obs_property_get_type(bitrate);
 	switch (type) {
 	case OBS_PROPERTY_INT:
-		return HandleIntProperty(bitrate, id);
+		return HandleIntProperty(bitrate, bitrates);
 
 	case OBS_PROPERTY_LIST:
-		return HandleListProperty(bitrate, id);
+		return HandleListProperty(bitrate, id, bitrates);
 
 	default:
 		break;
@@ -132,10 +131,75 @@ static const char *GetCodec(const char *id)
 	return NullToEmpty(obs_get_encoder_codec(id));
 }
 
-static void PopulateBitrateMap()
+static std::vector<int> fallbackBitrates;
+static map<std::string, std::vector<int>> encoderBitrates;
+
+static void PopulateBitrateLists()
 {
 	static once_flag once;
 
+	call_once(once, []() {
+		struct obs_audio_info aoi;
+		obs_get_audio_info(&aoi);
+		uint32_t output_channels = get_audio_channels(aoi.speakers);
+
+		/* NOTE: ffmpeg_aac and ffmpeg_opus have the same properties
+		 * their bitrates will also be used as a fallback */
+		HandleEncoderProperties("ffmpeg_aac", fallbackBitrates);
+
+		if (fallbackBitrates.empty())
+			blog(LOG_ERROR, "Could not enumerate fallback encoder "
+					"bitrates");
+
+		ostringstream ss;
+		for (auto &bitrate : fallbackBitrates)
+			ss << "\n	" << setw(3) << bitrate << " kbit/s:";
+
+		blog(LOG_DEBUG, "Fallback encoder bitrates:%s",
+		     ss.str().c_str());
+
+		const char *id = nullptr;
+		for (size_t i = 0; obs_enum_encoder_types(i, &id); i++) {
+			if (obs_get_encoder_type(id) != OBS_ENCODER_AUDIO)
+				continue;
+
+			if (strcmp(id, "ffmpeg_aac") == 0 ||
+			    strcmp(id, "ffmpeg_opus") == 0)
+				continue;
+
+			std::string encoder = id;
+
+			HandleEncoderProperties(id, encoderBitrates[encoder]);
+
+			if (encoderBitrates[encoder].empty())
+				blog(LOG_ERROR,
+				     "Could not enumerate %s encoder "
+				     "bitrates",
+				     id);
+
+			ostringstream ss;
+			for (auto &bitrate : encoderBitrates[encoder])
+				ss << "\n	" << setw(3) << bitrate
+				   << " kbit/s";
+
+			blog(LOG_DEBUG, "%s (%s) encoder bitrates:%s",
+			     EncoderName(id), id, ss.str().c_str());
+		}
+
+		if (encoderBitrates.empty() && fallbackBitrates.empty())
+			blog(LOG_ERROR, "Could not enumerate any audio encoder "
+					"bitrates");
+	});
+}
+
+static map<int, std::string> simpleAACBitrateMap;
+
+static void PopulateSimpleAACBitrateMap()
+{
+	PopulateBitrateLists();
+
+	static once_flag once;
+
 	call_once(once, []() {
 		const string encoders[] = {
 			"ffmpeg_aac",
@@ -148,7 +212,8 @@ static void PopulateBitrateMap()
 		struct obs_audio_info aoi;
 		obs_get_audio_info(&aoi);
 
-		HandleEncoderProperties(fallbackEncoder.c_str());
+		for (auto &bitrate : fallbackBitrates)
+			simpleAACBitrateMap[bitrate] = fallbackEncoder;
 
 		const char *id = nullptr;
 		for (size_t i = 0; obs_enum_encoder_types(i, &id); i++) {
@@ -160,48 +225,115 @@ static void PopulateBitrateMap()
 			    end(encoders))
 				continue;
 
-			if (strcmp(GetCodec(id), "AAC") != 0)
+			if (strcmp(GetCodec(id), "aac") != 0)
+				continue;
+
+			std::string encoder = id;
+			if (encoderBitrates[encoder].empty())
 				continue;
 
-			HandleEncoderProperties(id);
+			for (auto &bitrate : encoderBitrates[encoder])
+				simpleAACBitrateMap[bitrate] = encoder;
 		}
 
 		for (auto &encoder : encoders) {
 			if (encoder == fallbackEncoder)
 				continue;
 
-			if (strcmp(GetCodec(encoder.c_str()), "AAC") != 0)
+			if (strcmp(GetCodec(encoder.c_str()), "aac") != 0)
 				continue;
 
-			HandleEncoderProperties(encoder.c_str());
+			for (auto &bitrate : encoderBitrates[encoder])
+				simpleAACBitrateMap[bitrate] = encoder;
 		}
 
-		if (bitrateMap.empty()) {
+		if (simpleAACBitrateMap.empty()) {
 			blog(LOG_ERROR, "Could not enumerate any AAC encoder "
 					"bitrates");
 			return;
 		}
 
 		ostringstream ss;
-		for (auto &entry : bitrateMap)
+		for (auto &entry : simpleAACBitrateMap)
+			ss << "\n	" << setw(3) << entry.first
+			   << " kbit/s: '" << EncoderName(entry.second) << "' ("
+			   << entry.second << ')';
+
+		blog(LOG_DEBUG, "AAC simple encoder bitrate mapping:%s",
+		     ss.str().c_str());
+	});
+}
+
+static map<int, std::string> simpleOpusBitrateMap;
+
+static void PopulateSimpleOpusBitrateMap()
+{
+	PopulateBitrateLists();
+
+	static once_flag once;
+
+	call_once(once, []() {
+		struct obs_audio_info aoi;
+		obs_get_audio_info(&aoi);
+		uint32_t output_channels = get_audio_channels(aoi.speakers);
+
+		for (auto &bitrate : fallbackBitrates)
+			simpleOpusBitrateMap[bitrate] = "ffmpeg_opus";
+
+		const char *id = nullptr;
+		for (size_t i = 0; obs_enum_encoder_types(i, &id); i++) {
+			if (strcmp(GetCodec(id), "opus") != 0)
+				continue;
+
+			std::string encoder = id;
+			if (encoderBitrates[encoder].empty())
+				continue;
+
+			for (auto &bitrate : encoderBitrates[encoder])
+				simpleOpusBitrateMap[bitrate] = encoder;
+		}
+
+		if (simpleOpusBitrateMap.empty()) {
+			blog(LOG_ERROR, "Could not enumerate any Opus encoder "
+					"bitrates");
+			return;
+		}
+
+		ostringstream ss;
+		for (auto &entry : simpleOpusBitrateMap)
 			ss << "\n	" << setw(3) << entry.first
 			   << " kbit/s: '" << EncoderName(entry.second) << "' ("
 			   << entry.second << ')';
 
-		blog(LOG_DEBUG, "AAC encoder bitrate mapping:%s",
+		blog(LOG_DEBUG, "Opus simple encoder bitrate mapping:%s",
 		     ss.str().c_str());
 	});
 }
 
-const map<int, std::string> &GetAACEncoderBitrateMap()
+const map<int, std::string> &GetSimpleAACEncoderBitrateMap()
 {
-	PopulateBitrateMap();
-	return bitrateMap;
+	PopulateSimpleAACBitrateMap();
+	return simpleAACBitrateMap;
+}
+
+const map<int, std::string> &GetSimpleOpusEncoderBitrateMap()
+{
+	PopulateSimpleOpusBitrateMap();
+	return simpleOpusBitrateMap;
+}
+
+const char *GetSimpleAACEncoderForBitrate(int bitrate)
+{
+	auto &map_ = GetSimpleAACEncoderBitrateMap();
+	auto res = map_.find(bitrate);
+	if (res == end(map_))
+		return NULL;
+	return res->second.c_str();
 }
 
-const char *GetAACEncoderForBitrate(int bitrate)
+const char *GetSimpleOpusEncoderForBitrate(int bitrate)
 {
-	auto &map_ = GetAACEncoderBitrateMap();
+	auto &map_ = GetSimpleOpusEncoderBitrateMap();
 	auto res = map_.find(bitrate);
 	if (res == end(map_))
 		return NULL;
@@ -210,13 +342,13 @@ const char *GetAACEncoderForBitrate(int bitrate)
 
 #define INVALID_BITRATE 10000
 
-int FindClosestAvailableAACBitrate(int bitrate)
+static int FindClosestAvailableSimpleBitrate(int bitrate,
+					     const map<int, std::string> &map)
 {
-	auto &map_ = GetAACEncoderBitrateMap();
 	int prev = 0;
 	int next = INVALID_BITRATE;
 
-	for (auto val : map_) {
+	for (auto val : map) {
 		if (next > val.first) {
 			if (val.first == bitrate)
 				return bitrate;
@@ -234,3 +366,51 @@ int FindClosestAvailableAACBitrate(int bitrate)
 		return prev;
 	return 192;
 }
+
+int FindClosestAvailableSimpleAACBitrate(int bitrate)
+{
+	return FindClosestAvailableSimpleBitrate(
+		bitrate, GetSimpleAACEncoderBitrateMap());
+}
+
+int FindClosestAvailableSimpleOpusBitrate(int bitrate)
+{
+	return FindClosestAvailableSimpleBitrate(
+		bitrate, GetSimpleOpusEncoderBitrateMap());
+}
+
+const std::vector<int> &GetAudioEncoderBitrates(const char *id)
+{
+	std::string encoder = id;
+	PopulateBitrateLists();
+	if (encoderBitrates[encoder].empty())
+		return fallbackBitrates;
+	return encoderBitrates[encoder];
+}
+
+int FindClosestAvailableAudioBitrate(const char *id, int bitrate)
+{
+	int prev = 0;
+	int next = INVALID_BITRATE;
+	std::string encoder = id;
+
+	for (auto val : encoderBitrates[encoder].empty()
+				? fallbackBitrates
+				: encoderBitrates[encoder]) {
+		if (next > val) {
+			if (val == bitrate)
+				return bitrate;
+
+			if (val < next && val > bitrate)
+				next = val;
+			if (val > prev && val < bitrate)
+				prev = val;
+		}
+	}
+
+	if (next != INVALID_BITRATE)
+		return next;
+	if (prev != 0)
+		return prev;
+	return 192;
+}

UI/audio-encoders.hpp

@@ -3,7 +3,15 @@
 #include <obs.hpp>
 
 #include <map>
+#include <vector>
 
-const std::map<int, std::string> &GetAACEncoderBitrateMap();
-const char *GetAACEncoderForBitrate(int bitrate);
-int FindClosestAvailableAACBitrate(int bitrate);
+const std::map<int, std::string> &GetSimpleAACEncoderBitrateMap();
+const char *GetSimpleAACEncoderForBitrate(int bitrate);
+int FindClosestAvailableSimpleAACBitrate(int bitrate);
+
+const std::map<int, std::string> &GetSimpleOpusEncoderBitrateMap();
+const char *GetSimpleOpusEncoderForBitrate(int bitrate);
+int FindClosestAvailableSimpleOpusBitrate(int bitrate);
+
+const std::vector<int> &GetAudioEncoderBitrates(const char *id);
+int FindClosestAvailableAudioBitrate(const char *id, int bitrate);

UI/data/locale/en-US.ini

@@ -218,6 +218,7 @@ Basic.AutoConfig.TestPage="Final Results"
 Basic.AutoConfig.TestPage.SubTitle.Testing="The program is now executing a set of tests to estimate the ideal settings"
 Basic.AutoConfig.TestPage.SubTitle.Complete="Testing complete"
 Basic.AutoConfig.TestPage.TestingBandwidth="Performing bandwidth test, this may take a few minutes..."
+Basic.AutoConfig.TestPage.TestingBandwidth.NoOutput="No output for the protocol of this service was found"
 Basic.AutoConfig.TestPage.TestingBandwidth.Connecting="Connecting to: %1..."
 Basic.AutoConfig.TestPage.TestingBandwidth.ConnectFailed="Failed to connect to any servers, please check your internet connection and try again."
 Basic.AutoConfig.TestPage.TestingBandwidth.Server="Testing bandwidth for: %1"
@@ -941,7 +942,8 @@ Basic.Settings.Output.Format.HLS="HLS (.m3u8 + .ts)"
 Basic.Settings.Output.Format.fMP4="Fragmented MP4 (.mp4)"
 Basic.Settings.Output.Format.fMOV="Fragmented MOV (.mov)"
 Basic.Settings.Output.Format.TT="Fragmented MP4/MOV writes the recording in chunks and does not require the same finalization as traditional MP4/MOV files.\nThis ensures the file remains playable even if writing to disk is interrupted, for example, as a result of a BSOD or power loss.\n\nThis may not be compatible with all players and editors. Use File → Remux Recordings to convert the file into a more compatible format if necessary."
-Basic.Settings.Output.Encoder="Encoder"
+Basic.Settings.Output.Encoder.Video="Video Encoder"
+Basic.Settings.Output.Encoder.Audio="Audio Encoder"
 Basic.Settings.Output.SelectDirectory="Select Recording Directory"
 Basic.Settings.Output.SelectFile="Select Recording File"
 Basic.Settings.Output.DynamicBitrate="Dynamically change bitrate to manage congestion"
@@ -992,6 +994,7 @@ Basic.Settings.Output.Warn.EnforceResolutionFPS.Resolution="Resolution: %1"
 Basic.Settings.Output.Warn.EnforceResolutionFPS.FPS="FPS: %1"
 Basic.Settings.Output.Warn.ServiceCodecCompatibility.Title="Incompatible Encoder"
 Basic.Settings.Output.Warn.ServiceCodecCompatibility.Msg="The streaming service \"%1\" does not support the encoder \"%2\". The encoder will be changed to \"%3\".\n\nDo you want to continue?"
+Basic.Settings.Output.Warn.ServiceCodecCompatibility.Msg2="The streaming service \"%1\" does not support encoders \"%2\" and \"%3\". These encoders will be changed to \"%4\" and \"%5\".\n\nDo you want to continue?"
 Basic.Settings.Output.VideoBitrate="Video Bitrate"
 Basic.Settings.Output.AudioBitrate="Audio Bitrate"
 Basic.Settings.Output.Reconnect="Automatically Reconnect"