UI: Use keychain APIs for OAuth credentials#9146
Closed
derrod wants to merge 11 commits intoobsproject:masterfrom
Closed
UI: Use keychain APIs for OAuth credentials#9146derrod wants to merge 11 commits intoobsproject:masterfrom
derrod wants to merge 11 commits intoobsproject:masterfrom
Conversation
7d290c0 to
40cc184
Compare
40cc184 to
5c517f3
Compare
Member
|
Since this has an open and pending RFC as a requirement, we are opting to close this until the RFC has been finalized. The branch and discussion on implementation is welcome to take place on the RFC, and this may be reopened when the RFC is finalized. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is built on top of #9122 as a test/reference implementation for using the keychain APIs. It will require some rework whenever obsproject/rfcs#39 is done.
Motivation and Context
More secure credentials storage and good practice of revoking credentials once they're no longer neeed.
How Has This Been Tested?
Tested on Windows, Mac, and Linux.
Types of changes
Checklist: