cmake: Allow finding the CEF wrapper without a build folder on Linux#9794
Merged
Lain-B merged 1 commit intoobsproject:masterfrom Nov 4, 2023
Merged
Conversation
PatTheMav
approved these changes
Nov 3, 2023
Member
|
The CMake 3.0 path isn't being used yet on Linux, is it? Just want to determine the urgency on this. |
Member
Correct - this is effectively a companion to the Linux update, but that PR's scope is limited to updating our own Ubuntu-based build process and has no changes specifically for Flatpak (because it doesn't update the manifest yet). This change is specifically required to make Flatpak work with those changes. |
Lain-B
approved these changes
Nov 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This modify the CEF finder of CMake 3.0 framework, to restore a behavior that was supported with 2.0.
The Flatpak (and also my CEF AUR packages), do not generate/use a build folder to provide the wrapper.
Motivation and Context
I don't see a real reason to drop this behavior.
How Has This Been Tested?
Makes Flatpak on CMake 3.0 with #9787 (with other fixes e.g. fix GIO finder, disabling AJA) build.
Types of changes
Checklist: