Declare fields in PatchscopeBase #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also moves the Context classes to patchscope base to avoid circular dependency
Collaborator
|
This looks good to me. Do we need to change all imports of SourceContext and TargetContext in this PR, to account for this? |
Collaborator
Author
|
Let me make obvs.patchscope a package. Then have 3 files in it: patchscope, patchscope_base, and contexts. That way, each file is small and users can still import from obvs.patchscope. |
Collaborator
Author
|
I'll refactor after the FutureLens PR is merged to avoid conflict. |
Collaborator
Collaborator
Author
|
Thanks for the reminder @shaheenahmedc. I'll wait for you to merge #48 & #52 and then rebase this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
PatchscopeBase references the fields inside the child class Patchscope.
This breaks Intellisense. So, I'm declaring all fields inside PatchscopeBase.
Also moves the Context classes to patchscope base to avoid circular dependency
Testing
pytestpassed