Serve install script (only) from Dream server#182
Serve install script (only) from Dream server#182Leonidas-from-XIV wants to merge 2 commits intoocaml-dune:mainfrom
Conversation
Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
|
If everything is working now, could we hold off on any more updates that may impact service or correctness for the time being? |
|
I don't understand your comment. Should we then basically archive this repository? This PR is my suggestion on how to prevent accidents like #178, where I did not understand why there were two install scripts and just switched the URL without realizing that it would also change all the artifact links. This reduces the amount of I think dealing with it now is a good idea, as the way it works is fresh in our minds. If we come back to this repo at a later point in time like in like half a year, or someone else will take a look at it, they might struggle with the same issues and potentially cause the same bugs. |
shonfeder
left a comment
There was a problem hiding this comment.
Let's hold off on this until
- After the arc of the MSP work is done.
- We have a documented and effective strategy for testing these kinds of changes to ensure they don't break the existing service.
|
For the sake of information, this was decided when there wasn't the question of having a website to serve the "preview". Hence, everything was stored on get.dune.build. With this PR change, this is definitely better for the maintainability of the project 😄 With the rebranding, I'm wondering if the Also, small review but if you change that, you can remove this part from the end of the README: |
This PR moves the install script from the
get.dune.buildserver to the script served bynightly.dune.build.The previous setup used to copy the
installscript toget.dune.buildas part of the daily sync action, but this has some distinct disadvantagessyncaction to run until the new version is deployed. This two step process is tricky because it is easy to forget to run the action and then the script will only be updated on the next run (which might only happen after a few days if no changes to dune occur). This means that it can take multiple days until a change happens and things can be broken for a longer time (e.g. change over the weekend)get.dune.buildis used to host the binaries, but the fact that the install script is served by both thebinary-distributionDream app (which serves the most currently deployedmainversion) as well asget.dune.build(the latest version from the github action) is confusing. This simplifies the code base to always just use one of them.