Use config file instead of editing source code#210
Draft
Leonidas-from-XIV wants to merge 5 commits intoocaml-dune:mainfrom
Draft
Use config file instead of editing source code#210Leonidas-from-XIV wants to merge 5 commits intoocaml-dune:mainfrom
Leonidas-from-XIV wants to merge 5 commits intoocaml-dune:mainfrom
Conversation
05e9699 to
8fd7858
Compare
Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
The values are taken from the nightly workflow. Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
8fd7858 to
af72f6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the way Sandworm is reconfigured by moving from editing sourcecode as part of an GH workflow into using a config file.
Some notes about it:
testas an option to its execution. We need to rework how to test things in either case.Closes #199