nix: add outputs for each supported ocaml version#34
Open
Alizter wants to merge 3 commits intoocaml-dune:mainfrom
Open
nix: add outputs for each supported ocaml version#34Alizter wants to merge 3 commits intoocaml-dune:mainfrom
Alizter wants to merge 3 commits intoocaml-dune:mainfrom
Conversation
8f6d6e5 to
1383b17
Compare
Contributor
Author
|
Due to the way the devShell was setup, all the packages were being added as buildInputs. I've now restricted it to the two packages it was before. |
Contributor
|
Can you include the CI here? I don't know how to use any of this stuff so the only value is the CI |
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
1383b17 to
1a369e9
Compare
Contributor
Author
|
Here is the CI commits. Some further questions:
|
Collaborator
|
I believe an overlay approach would be a bit more lightweight ocaml/ocaml-lsp#1231 |
Contributor
|
Sure, doing it with overlays sounds good to me. Could you send a PR?
… On Mar 30, 2024, at 10:59 PM, Antonio Nuno Monteiro ***@***.***> wrote:
I believe an overlay approach would be a bit more lightweight ocaml/ocaml-lsp#1231 <ocaml/ocaml-lsp#1231>
—
Reply to this email directly, view it on GitHub <#34 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABB56ZBPLWWBFEMU7A5MKLY247UXAVCNFSM6AAAAABACDFRAKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRYGQ4DSMZTGQ>.
You are receiving this because you commented.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This let's us do
nix build .#fiber_4_09. CI PR will follow this one.Flakes unfortunately have this somewhat artificial restriction of only allowing "flake-like" values as inputs, meaning we can't parameterize the flake by arbitrary values. One way to get around that restriction is to create some local flakes for each OCaml version. I just opted for the simpler solution of adding the appropriate flake outputs.
Not all of them build however, as there are issues in the test suite for 4.09 for example. We can investigate that (and others) after this PR.