Floating point primitive #8
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #9
Overview
Threads the basic Float and Double primitives from libclang through the IR and then c/caml generation.
Features
floatinto the doggo exampleDouble_valcaml_copy_doublefunction is used (just referenced the docs for this :) )Future Improvements
I decided to just leave the fallback to
val_intandint_valfor now because if we want to do more intelligent matching there we probably need a way of either bubbling up errors or raising an exception and I don't want to touch that right now without having a proper discussion with you & others.I'm going to test out type aliases next (I usually typedef float and double to f32/f64 respectively for example).