Skip to content

test(path): trailing slashes when appending #14279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alizter merged 1 commit into from
Apr 21, 2026
Merged

test(path): trailing slashes when appending #14279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions otherlibs/stdune/test/path_tests.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,3 +705,20 @@ let%expect_test "path relative external plain" =
relative (Path.of_string "/ext") "foo";
[%expect {| External "/ext/foo" |}]
;;

let%expect_test "external relative trailing slash" =
external_relative "/root/" "foo/bar";
[%expect {| /root/foo/bar |}]
;;

(* CR-soon Alizter: should strip "./" and produce "/root/foo" *)
let%expect_test "external relative trailing slash dot-slash" =
external_relative "/root/" "./foo";
[%expect {| /root/./foo |}]
;;

(* CR-soon Alizter: should return "/root" *)
let%expect_test "external relative dot-slash only" =
external_relative "/root" "./";
[%expect {| /root/./ |}]
;;
Loading