Use Fpath.traverse in pkg_rules#14291
Merged
Alizter merged 1 commit intoocaml:mainfrom Apr 23, 2026
Merged
Conversation
Collaborator
|
Could you split the traversal change into a separate PR, that should be simpler to review. |
ElectreAAS
force-pushed
the
push-xxyzrmlroppn
branch
from
c8a731e to
23e1a2c
Compare
ElectreAAS
changed the title
There was a problem hiding this comment.
Pull request overview
Refactors pkg_rules symlink resolution logic to use Stdune.Fpath.traverse instead of manual recursive directory walking.
Changes:
- Replaced manual
Readdir.read_directory_with_kindsrecursion withFpath.traversefor scanningtarget_dir. - Kept behavior of replacing file symlinks (that ultimately resolve to regular files) with hardlinks for cache compatibility.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
Done -> #14301 |
Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com> Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
ElectreAAS
force-pushed
the
push-xxyzrmlroppn
branch
from
23e1a2c to
c063d37
Compare
Alizter
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a little change extracted from #13792, nothing changing dune behaviour.
Figured I'd use Fpath.traverse where it's appropriate