Skip to content

Conversation

raphael-proust
Copy link
Contributor

This pull-request concerns:

  • lwt.6.0.0~beta00: Promises and event-driven I/O
  • lwt_direct.6.0.0~beta00: Direct-style control-flow and await for Lwt


🐫 Pull-request generated by opam-publish v2.5.1

@raphael-proust
Copy link
Contributor Author

A few backwards compatibilities have been restored since the alphas. I'll make a separate PR to adjust the revdep packages.

@mseri
Copy link
Member

mseri commented Sep 22, 2025

Should we wait for that?
As an aside, does it supersede the alpha? Should we close the PR (unless already done?)

@mseri
Copy link
Member

mseri commented Sep 22, 2025

lwt_log is failing:

#=== ERROR while compiling lwt_log.1.1.2 ======================================#
# context              2.4.1 | linux/x86_64 | ocaml-base-compiler.4.14.2 | file:///home/opam/opam-repository
# path                 ~/.opam/4.14/.opam-switch/build/lwt_log.1.1.2
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p lwt_log -j 255
# exit-code            1
# env-file             ~/.opam/log/lwt_log-8-a2a2bd.env
# output-file          ~/.opam/log/lwt_log-8-a2a2bd.out
### output ###
# (cd _build/default && /home/opam/.opam/4.14/bin/ocamlc.opt -w -40 -w +A -g -bin-annot -I src/unix/.lwt_log.objs/byte -I /home/opam/.opam/4.14/lib/bytes -I /home/opam/.opam/4.14/lib/domain_shims -I /home/opam/.opam/4.14/lib/lwt -I /home/opam/.opam/4.14/lib/lwt/unix -I /home/opam/.opam/4.14/lib/ocaml/threads -I /home/opam/.opam/4.14/lib/ocplib-endian -I /home/opam/.opam/4.14/lib/ocplib-endian/bigstring -I src/core/.lwt_log_core.objs/byte -intf-suffix .ml -no-alias-deps -o src/unix/.lwt_log.objs/byte/lwt_daemon.cmo -c -impl src/unix/lwt_daemon.ml)
# File "src/unix/lwt_daemon.ml", line 64, characters 49-68:
# 64 |     Lwt_sequence.iter_node_l Lwt_sequence.remove Lwt_main.exit_hooks [@ocaml.warning "-3"];
#                                                       ^^^^^^^^^^^^^^^^^^^
# Error: Unbound value Lwt_main.exit_hooks
# (cd _build/default && /home/opam/.opam/4.14/bin/ocamlopt.opt -w -40 -w +A -g -I src/unix/.lwt_log.objs/byte -I src/unix/.lwt_log.objs/native -I /home/opam/.opam/4.14/lib/bytes -I /home/opam/.opam/4.14/lib/domain_shims -I /home/opam/.opam/4.14/lib/lwt -I /home/opam/.opam/4.14/lib/lwt/unix -I /home/opam/.opam/4.14/lib/ocaml/threads -I /home/opam/.opam/4.14/lib/ocplib-endian -I /home/opam/.opam/4.14/lib/ocplib-endian/bigstring -I src/core/.lwt_log_core.objs/byte -I src/core/.lwt_log_core.objs/native -intf-suffix .ml -no-alias-deps -o src/unix/.lwt_log.objs/native/lwt_daemon.cmx -c -impl src/unix/lwt_daemon.ml)
# File "src/unix/lwt_daemon.ml", line 64, characters 49-68:
# 64 |     Lwt_sequence.iter_node_l Lwt_sequence.remove Lwt_main.exit_hooks [@ocaml.warning "-3"];
#                                                       ^^^^^^^^^^^^^^^^^^^
# Error: Unbound value Lwt_main.exit_hooks

We could add an upper bound in the pr adjusting the other bounds

@raphael-proust
Copy link
Contributor Author

I made #28641 to fix the incompatibilities

@raphael-proust raphael-proust force-pushed the opam-publish-lwt.6.0.0-beta00 branch from 7753d1b to db50ce0 Compare October 3, 2025 13:27
@mseri
Copy link
Member

mseri commented Oct 7, 2025

I have retriggered the build. Let's see if we can merge now

@mseri mseri removed the question label Oct 7, 2025
@mseri
Copy link
Member

mseri commented Oct 10, 2025

Can you check: lwt_direct.6.0.0~beta00
lower-bounds (failed: This expression has type Lwt.Private.storage ref)

Also there are some segmentation faults among the failures, and I fear also cohttp weird failure without error may be one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants