Skip to content

direct load detach task support 451 #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suz-yang wants to merge 1 commit into
base: master
Choose a base branch
from
Open

direct load detach task support 451 #419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/java/com/alipay/oceanbase/rpc/ObGlobal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,8 @@ public static boolean isDistributeNeedTabletIdSupport() {

public static final long OB_VERSION_4_5_0_0 = calcVersion(4, (short) 5, (byte) 0, (byte) 0);

public static final long OB_VERSION_4_5_1_0 = calcVersion(4, (short) 5, (byte) 1, (byte) 0);

public static long OB_VERSION = calcVersion(0, (short) 0, (byte) 0, (byte) 0);

/*-------------------------------------------- OB_PROXY_VERSION --------------------------------------------*/
Expand Down
12 changes: 7 additions & 5 deletions src/main/java/com/alipay/oceanbase/rpc/direct_load/protocol/v0/ObDirectLoadProtocolV0.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,14 @@ public ObDirectLoadDetachRpc getDetachRpc(ObDirectLoadTraceId traceId)
+ " is not supported, minimum version required is "
+ ObGlobal.getObVsnString(ObGlobal.OB_VERSION_4_4_2_0));
}
} else {
} else if (obVersion < ObGlobal.OB_VERSION_4_5_1_0) {
logger.warn("detach in ob version " + ObGlobal.getObVsnString(obVersion)
+ "is not supported");
throw new ObDirectLoadNotSupportedException("detach in ob version "
+ ObGlobal.getObVsnString(obVersion)
+ " is not supported");
+ "is not supported, minimum version required is "
+ ObGlobal.getObVsnString(ObGlobal.OB_VERSION_4_5_1_0));
throw new ObDirectLoadNotSupportedException(
"detach in ob version " + ObGlobal.getObVsnString(obVersion)
+ " is not supported, minimum version required is "
+ ObGlobal.getObVsnString(ObGlobal.OB_VERSION_4_5_1_0));
}
return new ObDirectLoadDetachRpcV0(traceId);
}
Expand Down