Indexer Refactoring Strategy Documentation#1182
Conversation
|
/run-security-scan |
alexcos20
left a comment
There was a problem hiding this comment.
AI automated code review (Gemini 3).
Overall risk: low
Summary:
This pull request introduces a comprehensive documentation outlining a refactoring strategy for the Ocean Node Indexer focusing on enhanced event monitoring, error handling, and overall resilience. The document proposes moving to a queue-based system, introducing a new ddo_logs index for better tracking, and improving retry mechanisms. The proposed changes are well-articulated and address critical pain points in the current indexer architecture.
Comments:
• [ERROR][style] There's a typo in the link to the existing architecture document. Arhitecture.md should be Architecture.md.
• [WARNING][other] The status mentions Jan 27, 2026. Given the current date, this seems to be a date in the future. Could this be a typo and should be Jan 27, 2024? If it's intentionally a future date, it might be good to clarify that this is a forward-looking strategy proposal for that date.
• [INFO][style] For consistency with did and eventType, consider adding // Indexed to chainId in the DdoLog interface, as it's stated as 'Indexed' in the description for query capabilities.
• [INFO][style] In section 1, EVENT_ERROR_PROCESSING_QUEUE is described. In this section, EVENT_PROCESSING_QUEUE (primary) is listed. While contextually related, it might be beneficial to explicitly state if EVENT_ERROR_PROCESSING_QUEUE is a specific instance/use case of the broader EVENT_PROCESSING_QUEUE, or if they are intended to be distinct but related queues. A small clarification could improve understanding of the overall queue landscape.
Fixes #1173 .
Changes proposed in this PR: