upgrades: sbt 1.1.1, sjs 0.6.22, and more#76
Open
ryan-williams wants to merge 3 commits intoochrons:masterfrom
Open
upgrades: sbt 1.1.1, sjs 0.6.22, and more#76ryan-williams wants to merge 3 commits intoochrons:masterfrom
ryan-williams wants to merge 3 commits intoochrons:masterfrom
Conversation
KGoodale13
added a commit
to KGoodale13/scalajs-spa-tutorial
that referenced
this pull request
Apr 18, 2018
Thanks to: https://github.com/mohiva/play-silhouette-angular-seed/ for the silhouette example And thanks to: ochrons#76 For some of the version updates needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this tutorial is awesome, thanks!
I'm new to Play and some of the libraries here so some of this is dumb pattern-matching (
InjectedController) that may not be the right way to do things.I also disabled CSRF checking because it was 403'ing all requests; it will probably be good to fix that before merging.
Moving the
Settings.scalaintobuild.sbtto be idiomatic SBT 1.x style is a possible addition as well.