[IMP] tests: Fixed unit tests after res.bank removal #358
+7
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
hsal-odoo
force-pushed
the
master-bank_ux-hsal
branch
5 times, most recently
from
02ca3fc to
a8057a7
Compare
hsal-odoo
force-pushed
the
master-bank_ux-hsal
branch
from
a8057a7 to
a2c5bd1
Compare
Contributor
|
upgradeci retry with base in all versions |
aj-fuentes
reviewed
Dec 19, 2025
aj-fuentes
reviewed
Dec 19, 2025
hsal-odoo
force-pushed
the
master-bank_ux-hsal
branch
from
a2c5bd1 to
610b827
Compare
aj-fuentes
reviewed
Dec 19, 2025
| util.flush(p1) | ||
| with self.assertRaises(AssertionError), self.assertUpdated("res_bank", ids=[]): | ||
| self.env["res.bank"].create({"name": "Annie Leonhart"}) | ||
| with self.assertRaises(AssertionError), self.assertUpdated("res_partner", ids=[]): |
Contributor
There was a problem hiding this comment.
@jjmaksoud could you have a quick look if this part is fine? It looks OK to me.
Contributor
|
upgradeci retry with base in all versions |
Contributor
|
@robodoo r+ |
Contributor
|
@hsal-odoo @aj-fuentes linked pull request(s) odoo/enterprise#99418, odoo/odoo#234974 not ready. Linked PRs are not staged until all of them are ready. |
This commit fixes the upgrade-util tests that failed due to the removal of res.bank model. The model res.bank was replaced with res.partner. task-5145618
hsal-odoo
force-pushed
the
master-bank_ux-hsal
branch
from
610b827 to
5a1af1d
Compare
Contributor
|
@robodoo r+ |
jjmaksoud
reviewed
Dec 22, 2025
Contributor
jjmaksoud
left a comment
jjmaksoud
left a comment
There was a problem hiding this comment.
The failure in saas~12.3 when the assert uses create and id=[] is due to how the orm back then created a record then updated its computed fields in separate queries. It was working by chance simply because re.bank did not have any stored computed fields. I will do a followup pr to address this limitation
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Dec 22, 2025
This commit improves the UX of bank accounts by: 1. removing res.bank model 2. removes localizations redundancy 3. some fields in localizations should be available to all companies 4. most countries had missing fields task-5145618 closes #234974 Related: odoo/enterprise#99418 Related: odoo/upgrade#8958 Related: odoo/upgrade-util#358 Signed-off-by: Fabien Pinckaers (fp) <fp@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Dec 22, 2025
This commit fixes the upgrade-util tests that failed due to the removal of res.bank model. The model res.bank was replaced with res.partner. task-5145618 closes #358 Related: odoo/odoo#234974 Related: odoo/enterprise#99418 Related: odoo/upgrade#8958 Signed-off-by: Alvaro Fuentes Suarez (afu) <afu@odoo.com>
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Dec 22, 2025
This commit improves the UX of bank accounts by: 1. removing res.bank model 2. removes localizations redundancy 3. some fields in localizations should be available to all companies 4. most countries had missing fields task-5145618 closes #234974 Related: odoo/enterprise#99418 Related: odoo/upgrade#8958 Related: odoo/upgrade-util#358 Signed-off-by: Fabien Pinckaers (fp) <fp@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Dec 22, 2025
This commit fixes the upgrade-util tests that failed due to the removal of res.bank model. The model res.bank was replaced with res.partner. task-5145618 closes #358 Related: odoo/odoo#234974 Related: odoo/enterprise#99418 Related: odoo/upgrade#8958 Signed-off-by: Alvaro Fuentes Suarez (afu) <afu@odoo.com>
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Dec 22, 2025
This commit improves the UX of bank accounts by: 1. removing res.bank model 2. removes localizations redundancy 3. some fields in localizations should be available to all companies 4. most countries had missing fields task-5145618 closes #234974 Related: odoo/enterprise#99418 Related: odoo/upgrade#8958 Related: odoo/upgrade-util#358 Signed-off-by: Fabien Pinckaers (fp) <fp@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Dec 22, 2025
This commit fixes the upgrade-util tests that failed due to the removal of res.bank model. The model res.bank was replaced with res.partner. task-5145618 closes #358 Related: odoo/odoo#234974 Related: odoo/enterprise#99418 Related: odoo/upgrade#8958 Signed-off-by: Alvaro Fuentes Suarez (afu) <afu@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the upgrade-util tests that failed due to the removal of res.bank model. The model res.bank was replaced with res.partner.
task-5145618