Skip to content

Run CI on all commits of a PR#22

Merged
odudex merged 2 commits intoodudex:masterfrom
pythcoiner:ci
Apr 18, 2026
Merged

Run CI on all commits of a PR#22
odudex merged 2 commits intoodudex:masterfrom
pythcoiner:ci

Conversation

@pythcoiner
Copy link
Copy Markdown
Collaborator

@pythcoiner pythcoiner commented Apr 18, 2026

This PR:

  • move all scripts into a dedicated directory
  • add a CI task that will run build formating + tests for all commits added behind HEAD

Relocate format.sh, test.sh, and release.sh to scripts/ so all
first-party shell tooling lives in one place. Each script now derives
REPO_ROOT from SCRIPT_DIR so internal paths still resolve from the
repo root. Callers in .justfile, CI, and CONTRIBUTING.md are updated
to the new path.
@pythcoiner pythcoiner force-pushed the ci branch 2 times, most recently from 9b5ed6f to 64c6f1f Compare April 18, 2026 18:11
Add scripts/ci-checks.sh bundling format check, tests, and wave_4b
build, and a new test-each-commit workflow that iterates every
commit of a PR (except the tip, which is already covered by
github-actions-test.yml) via git rebase --exec. This catches
regressions in intermediate commits that would otherwise slip
through when a later commit fixes them.

Modelled on Bitcoin Core's test-each-commit job.
@pythcoiner pythcoiner force-pushed the ci branch 2 times, most recently from 122af5d to c4a5140 Compare April 18, 2026 18:45
@pythcoiner pythcoiner changed the title Ci Run CI on all commits of a PR Apr 18, 2026
@pythcoiner pythcoiner marked this pull request as ready for review April 18, 2026 18:48
@pythcoiner
Copy link
Copy Markdown
Collaborator Author

tested by adding 2 commits, first braking a test, seconf fixing it, the task fail as expected on the commit breaking the test even if the HEAD is clean

@pythcoiner pythcoiner requested a review from odudex April 18, 2026 18:49
Copy link
Copy Markdown
Owner

@odudex odudex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, will require cleaner PRs

@odudex
Copy link
Copy Markdown
Owner

odudex commented Apr 18, 2026

I will also start to contribute with PRs instead of direct merges

@odudex odudex merged commit c0f6bcf into odudex:master Apr 18, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants