Conversation
Owner
odudex
commented
Apr 24, 2026
odudex
commented
- fix(display): clear stale framebuffer on warm reset to fix a graphical bug on splash screen
- fix(wallet_settings): prevent Apply button crop, distribute items evenly
- fix(wallet_settings): preserve pending edits across descriptor manager trip
fix graphical bug on splash screen
…r trip Returning from the descriptor manager unconditionally called `refresh_wallet_attributes()`, which re-read `wallet_get_network/policy/account()` and reset `settings_changed = false` wiping any pending user edits and disabling the Apply button even when the user had only opened the descriptor manager without loading anything. Have `descriptor_manager` expose a `descriptor_manager_was_changed()` getter (same pattern as `wallet_settings_were_applied()`), set to true on the two actual load paths: QR validation success and storage (flash/SD) load success. `wallet_settings` only resyncs from the wallet when that signal fires, so a no-op trip preserves pending edits while a real descriptor load correctly overwrites them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.