Open
Conversation
Contributor
Author
|
Can you guys check this out |
Marks Phase 3 auth as complete and inserts a new Phase 4 for Stripe Integration and SaaS Onboarding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request completes Phase 3 Authentication requirements by addressing several outstanding technical debts and completely modernizing the project's developer setup experience.
Summary of changes:
make setup, a command that automatically downloads and installs$GOPATH/binGo libraries (swag,goose,pkgsite,gomarkdoc, andgolangci-lintv1.64). Updated the README.md to reflect this prerequisite step.refresh_tokens, securely tying long-lived sessions touser_idinside the database upon login.2024initial migration SQL files by utilizinggoose fixto format them into a proper sequential rollout (00001,00002,00003).BearerJSON Web Tokens and insert the user claims into the HTTP Context securely. Created a RequirePermission(resource.action) middleware which queries the JSONB permission matrix attached to the requested staff member, preventing unauthorized access to protected endpoints.*with a dynamicAllowedOriginsvariable populated by the newCORS_ALLOWED_ORIGINS.envstring.Fixes # (issue)
Type of change
How Has This Been Tested?
make setup->make migrate-up->make test->make lint->make build) locally across Docker on macOS to certify system-level environment robustness and Go 1.23+ backwards compatibility.Performance (Optional)
Not currently benchmarked via
make benchmark, although cryptographic hashing additions naturally increase latency slightly during login.Checklist:
make test)make lintand fixed any issuesmake migrate-up(if applicable) and verified database changesmake swagger(if applicable) and updated API docs