Master

[offx-zinth]

No description provided.

[gemini-code-assist]

Code Review

This pull request significantly expands the SMP MCP toolset by adding multi-language support for Rust, Java, and TypeScript, alongside new tools for community detection, diffing, and telemetry. It includes comprehensive evaluation reports and a real-world test codebase to validate the system's production readiness. Feedback from the review identifies critical issues in the Rust parser regarding incorrect import semantics and broken cross-file dependency tracing. Furthermore, the removal of a default value in NavigateParams is noted as a breaking change, and the BFS pathfinding logic in the query engine contains unreachable code that should be simplified.

[gemini-code-assist]

The _process_use implementation has several issues:

1. It creates a new node of type FILE for every import, which is semantically incorrect as imports are references to modules or entities, not files.
2. Including file_path in make_node_id causes duplicate nodes to be created for the same module if it is imported in multiple files, fragmenting the dependency graph.
3. It uses EdgeType.DEPENDS_ON, but the query engine's assess_impact and find_flow tools do not currently follow this edge type, meaning these dependencies will be ignored during analysis.

[gemini-code-assist]

Generating target_id using the current file_path for all function calls assumes that the callee is always located in the same file. This breaks cross-file dependency tracing for Rust code. Callees should be identified in a way that allows the graph builder to resolve them across file boundaries (e.g., using only the name or a special placeholder).

[gemini-code-assist]

Removing the default value for the query field makes it a required parameter in the NavigateParams struct. This is a breaking change that will cause validation errors in any existing code or stored configurations that instantiate this struct without an explicit query string.

[gemini-code-assist]

The logic for adding neighbors contains unreachable code. Since self._graph.get_edges(current, direction=direction) already filters edges based on the specified direction, the elif blocks checking for the opposite direction (e.g., checking e.target_id == current when direction is outgoing) will never be executed. The logic can be simplified.

Suggested change

	# In outgoing direction, we follow source -> target
	# In incoming direction, we follow target -> source
	if direction == "outgoing":
	if e.source_id == current:
	neighbors.add(e.target_id)
	elif e.target_id == current:
	# Handle reverse edges if applicable
	neighbors.add(e.source_id)
	else: # incoming
	if e.target_id == current:
	neighbors.add(e.source_id)
	elif e.source_id == current:
	neighbors.add(e.target_id)
	for e in filtered_edges:
	neighbors.add(e.target_id if direction == "outgoing" else e.source_id)