Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9c8ec21479
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| with open(config_file) as f: | ||
| config_data = yaml.safe_load(f) | ||
| config_data = yaml.safe_load(f) or {} |
There was a problem hiding this comment.
Default only null YAML to empty config
Using yaml.safe_load(f) or {} coerces any falsy top-level YAML value (for example [], false, 0, or "") into {}. In those inputs, config export now silently changes the data instead of exporting what is actually on disk, and users who re-import the export can overwrite their config shape unintentionally. The empty-file fix should only apply when safe_load returns None.
Useful? React with 👍 / 👎.
| ### Python Environment Details | ||
|
|
||
| All Python services in the AITBC container run on **Python 3.11+** with isolated virtual environments: | ||
| All Python services in the AITBC container run on **Python 3.8+** with isolated virtual environments: |
There was a problem hiding this comment.
Keep documented Python minimum aligned with runtime
This change documents the infrastructure runtime as Python 3.8+, but service code uses syntax that is not valid on 3.8 (for example built-in generics like dict[str, ...] in apps/coordinator-api/src/app/routers/admin.py). Operators following this guide can provision an unsupported interpreter and hit syntax errors at startup, so the documented minimum here should match the actual service runtime requirement.
Useful? React with 👍 / 👎.
Motivation
config exportbehavior remains robust for an empty YAML file by adding a test that captures the expected output.Description
docs/8_development/1_overview.mdto replace non-existent internal links with existing targets and corrected the issue tracker URL and several Next Steps/Contributing links.test_export_empty_yamltotests/cli/test_config.pyto verify that an empty.aitbc.yamlexported with--format jsonreturns an empty JSON object ({}).docs/issues/2026-02-17-codebase-task-vorschlaege.mdas the actionable items were implemented.Testing
PYTHONPATH=cli pytest -q tests/cli/test_config.pywhich completed successfully with31 passed.docs/8_development/1_overview.mdwhich reported no missing local links.Codex Task