Feature: Browser-based (SSO) authentication + session keep-alive#77
Open
cwbr wants to merge 5 commits intooisee:mainfrom
Open
Feature: Browser-based (SSO) authentication + session keep-alive#77cwbr wants to merge 5 commits intooisee:mainfrom
cwbr wants to merge 5 commits intooisee:mainfrom
Conversation
Author
|
Solves #30 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds browser-based SSO authentication (Kerberos, SAML, Keycloak) and automatic session keep-alive to prevent idle timeouts — especially useful for cookie/browser-auth sessions.
Browser-Based SSO Authentication
Opens a Chromium browser for SSO login, captures session cookies, and passes them to the ADT client. Supports SAML, Kerberos, Keycloak, and form-based login flows.
New files:
New CLI flags:
--browser-authSAP_BROWSER_AUTH--browser-auth-timeoutSAP_BROWSER_AUTH_TIMEOUT--browser-execSAP_BROWSER_EXEC--cookie-saveSAP_COOKIE_SAVE--cookie-fileUsage:
Session Keep-Alive
Background goroutine sends periodic HEAD requests to
/sap/bc/adt/core/discoveryto keep the SAP session alive during idle periods. Refreshes the CSRF token as side effect.--keepaliveSAP_KEEPALIVE5m0to disable)Changed files:
Ping()method on TransportStartKeepAlive()/StopKeepAlive()with goroutine lifecycle managementKeepAliveIntervalconfig field, auto-start inNewServer()Documentation
Updated configuration tables in README.md and CLAUDE.md with all new flags.
Dependencies
Added
github.com/chromedp/chromedp+github.com/chromedp/cdprotofor headless browser control.