Conversation
-No custom checkbox -Poor css positioning
-todo_item text was not multiline -todo_remove button affected layout when hidden/shown -active modifier now works
DmitryMakhnev
left a comment
DmitryMakhnev
left a comment
There was a problem hiding this comment.
Пожалуйста приведите стили в порядок, т.к. на данный момент есть дублирование
Ознакомьтесь с разбором дз
Переведите всё на scss
| } | ||
|
|
||
| @font-face { | ||
| font-family: Helvetica-Neue-UltraLight; |
There was a problem hiding this comment.
Это платные шрифты, их не надо подключать
| src: url(../fonts/HelveticaNeue-UltraLight.otf); | ||
| } | ||
|
|
||
| body { |
| font-size: 14pt; | ||
| } | ||
|
|
||
| .todos_filters { |
There was a problem hiding this comment.
Идентично проблеме ok-technopolis/Shvedov_Oleg#4 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-No custom checkbox
-__active modifier doesn't work
-Poor css positioning