Open
Conversation
Contributor
nigelbabu
commented
Apr 20, 2015
nigelbabu
commented
- Update the dockerfile formatting
- Change how nodejs is installed to be in accordance with official recommendation.
- Clean up a bit of the docker role so it's up-to-date on how we actually run docker these days.
Contributor
|
Broadly looks fine so far, apart from the PPA stuff. |
Don't actually run a random shell script fetched from curl as root.
Contributor
|
Ok looks good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.