[wip] Add good bash defaults to backup scripts#47
Open
nigelbabu wants to merge 1 commit intookfn:masterfrom
Open
[wip] Add good bash defaults to backup scripts#47nigelbabu wants to merge 1 commit intookfn:masterfrom
nigelbabu wants to merge 1 commit intookfn:masterfrom
Conversation
Also make space consistent to be spaces
Contributor
|
I have tested the script and if you set it to set -o errexit (or set -e) the script fails. So I'm not able to accept the PR just yet. It's a good idea to have a set of defaults however. |
Contributor
Author
|
I'm going to shelve this for later. It needs a bit of tweaking on how it checks for excluded databases. |
nigelbabu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also make space consistent to be spaces