Show HTML entities literally in the output #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DoT intentionally does not encode an ampersand if it is a part of HTML entity (btw, why? @olado).
In index.html, event handlers call DoT and apply
String#encodeHTMLafterwards, which annihilates any difference between{{= }}and{{! }}for the reason described above. As a result, it is impossible to spot any difference between those two in the output.The patch in question fixes this behavior by encoding ampersands by hand before applying
String#encodeHTML.P.S. Why does all the JavaScript have to fit in a (huge) single line?