Skip to content

Conversation

@olbrich
Copy link
Owner

@olbrich olbrich commented Dec 21, 2025

This pull request introduces integration with Qlty Cloud for code coverage reporting, adds configuration files for Qlty, and makes several minor code and configuration improvements. The most significant changes are grouped below.

Qlty Cloud Integration:

  • Added Qlty Cloud coverage reporting to the GitHub Actions workflow by invoking qlty-action/coverage after tests, using a secret token and the coverage result file.
  • Added .qlty/qlty.toml configuration file and .qlty/.gitignore to support Qlty CLI and Cloud, specifying exclude and test patterns, code smell thresholds, and source configuration. [1] [2]

Configuration and Linting Improvements:

  • Updated .rubocop.yml to use the new plugins key instead of the deprecated require for RuboCop extensions.

Code Quality and Minor Fixes:

  • Improved boolean logic and code clarity in lib/ruby_units/unit.rb and lib/ruby_units/math.rb by simplifying conditionals and using more idiomatic Ruby syntax. [1] [2]
  • Made minor improvements to string formatting and parsing in lib/ruby_units/unit.rb for better readability and maintainability. [1] [2] [3]
  • Minor fix in test spec to remove unnecessary parentheses in the construction of a RubyUnits::Unit.

These changes collectively enhance test coverage visibility, code quality, and maintainability.

@olbrich olbrich self-assigned this Dec 21, 2025
@olbrich olbrich changed the title Add coverage step to GitHub Actions workflow Setup QLTY for code coverage and liniting Dec 21, 2025
@olbrich olbrich marked this pull request as ready for review December 21, 2025 21:29
@olbrich olbrich requested a review from Copilot December 21, 2025 21:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request integrates Qlty Cloud for code coverage reporting and implements various code quality improvements identified by linting tools. The changes modernize configuration files and refactor code to use more idiomatic Ruby syntax without altering functionality.

  • Adds Qlty Cloud integration to GitHub Actions workflow for automated code coverage reporting
  • Updates RuboCop configuration to use the modern plugins key instead of deprecated require
  • Refactors boolean logic and string interpolation to more idiomatic Ruby patterns

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/tests.yml Adds Qlty coverage reporting step after test execution
.qlty/qlty.toml Auto-generated Qlty configuration with code smell thresholds and exclusion patterns
.qlty/.gitignore Gitignore rules for Qlty directory to track only configuration files
.rubocop.yml Updates to use modern plugins configuration key
lib/ruby_units/unit.rb Simplifies boolean logic, improves string interpolation idioms, and adds rubocop disable comments
lib/ruby_units/math.rb Removes unnecessary parentheses in compound boolean expressions
spec/ruby_units/math_spec.rb Removes unnecessary parentheses in test subject definition

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@olbrich olbrich merged commit 62f2058 into master Dec 22, 2025
15 of 16 checks passed
@olbrich olbrich deleted the qlty-setup branch December 22, 2025 15:20
@olbrich olbrich changed the title Setup QLTY for code coverage and liniting Setup QLTY for code coverage and linting Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants