Skip to content

unique_impl_ptr: fix bug in operator< #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meator wants to merge 1 commit into
base: master
Choose a base branch
from
Open

unique_impl_ptr: fix bug in operator< #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions spimpl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,8 +268,8 @@ namespace spimpl {
template <class T1, class D1, class T2, class D2>
inline bool operator< (const unique_impl_ptr<T1, D1>& l, const unique_impl_ptr<T2, D2>& r)
{
using P1 = typename unique_impl_ptr<T1, D1>::pointer;
using P2 = typename unique_impl_ptr<T2, D2>::pointer;
using P1 = typename unique_impl_ptr<T1, D1>::const_pointer;
using P2 = typename unique_impl_ptr<T2, D2>::const_pointer;
using CT = typename std::common_type<P1, P2>::type;
return std::less<CT>()(l.get(), r.get());
}
Expand Down Expand Up @@ -319,14 +319,14 @@ namespace spimpl {
template <class T, class D>
inline bool operator< (const unique_impl_ptr<T, D>& l, std::nullptr_t)
{
using P = typename unique_impl_ptr<T, D>::pointer;
using P = typename unique_impl_ptr<T, D>::const_pointer;
return std::less<P>()(l.get(), nullptr);
}

template <class T, class D>
inline bool operator< (std::nullptr_t, const unique_impl_ptr<T, D>& p)
{
using P = typename unique_impl_ptr<T, D>::pointer;
using P = typename unique_impl_ptr<T, D>::const_pointer;
return std::less<P>()(nullptr, p.get());
}

Expand Down