Conversation
flaw fixed in InviteCommand, the else if ch is nullptr sends a response and returns now. Also if you change nick it won't send you the message multiple times.
operator parts. Also moved macros to separate header and added even more of them.
|
I'm starting to like this macro approach more and more. Moving stuff to Server constructor makes sense. And now we only create a persistent CommandDispatcher instance per Client, just like a User, which makes more sense from memory usage point. Probably one instance would've been enough, this works too. Its way faster as there is only one initialization for connecting client instead of one per request. Overall from my perspective it makes sense to merge all of these changes instead of fixing these again separately. If not there is one crucial fix here, I made a mistake that Channel was not removed from the User in the case that it became empty and was removed from Server, so that would need to be patched anyways. |
|
Closing as these changes are already incorporated into a newer pull request. |
1 participant
...but really nothing major changed logically. This is a draft and more of a RFC. More changes like this could still be done. For me it improves readability, someone might see it otherwise.