Conversation
flaw fixed in InviteCommand, the else if ch is nullptr sends a response and returns now. Also if you change nick it won't send you the message multiple times.
operator parts. Also moved macros to separate header and added even more of them.
…mart pointers now
v-kuu
approved these changes
Sep 22, 2025
Collaborator
v-kuu
left a comment
v-kuu
left a comment
There was a problem hiding this comment.
Nice work and useful bot. I tested it with various edge cases and everything seems to be handled correctly, except that it doesn't update it's internal list of operators for a channel when an operator leaves the channel. Minor issue though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be ok to evaluate. To me the bot could use a Bot.cpp & Bot.hpp so a class which constructor initializes the connection with the server. And many of those helper functions could be private methods. Other thing is whether the macro usage helps or hurts readability. For me it helps as there are now less characters and more cases in Command.cpp and highlighting makes it easier on the eyes.
I think the Server class still needs to close all the remaining fd's in _clients map. Even though they are closed by the operating system this is just for school's sake. Maybe the setLimit also needs the stoul positions is null trick for tricky tricksters. This is release candidate 1 for a reason so comment the code and discuss. 👍🏼