1.0.rc2#90
Merged
oliynykmax merged 7 commits intomainfrom Sep 26, 2025
Merged
Conversation
…et into epoll in the constructor. Also poll now checks whether event fd matches socket and just runs Handler::acceptClient
Server map a shared_ptr. So syntax changes mostly, except in Client and Server.
Closed
Server map a shared_ptr. So syntax changes mostly, except in Client and Server.
branch had Client stored as a shared_ptr)
jotuel
changed the title
Collaborator
Author
|
This really oughta be the last one in this series. Real pleasure working with ya gents. Catch ya on the flipside. 🫡 |
but these changes fix that.
oliynykmax
approved these changes
Sep 26, 2025
Owner
oliynykmax
left a comment
oliynykmax
left a comment
There was a problem hiding this comment.
Happy to see those memory changes. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was able to remove copy constructor and copy assigment overload from Client as they were no longer in use after switching to shared_ptr. Closes #89, fixes #86 and merges fix #83