Skip to content

fix: issue where client receives already hashed client_secret #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: issue where client receives already hashed client_secret #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions oauth_dcr/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,15 @@ def post(self, request):

# Create the application
try:
application = self._create_application(processed_metadata)
application, client_secret = self._create_application(processed_metadata)
except Exception as e:
logger.exception(f"Failed to create application: {e}")
return self._error_response("server_error",
"Failed to register client", 500)

# Restore the unhashed client secret for response
application.client_secret = client_secret

# Return client information response
return self._success_response(application, processed_metadata["token_endpoint_auth_method"])

Expand Down Expand Up @@ -228,15 +231,21 @@ def _validate_client_metadata(self, metadata):

def _create_application(self, metadata):
"""Create Application instance from validated metadata"""
application = Application.objects.create(
application = Application(
name=metadata.get("name", ""),
client_type=metadata["client_type"],
authorization_grant_type=metadata["authorization_grant_type"],
redirect_uris=metadata.get("redirect_uris", ""),
# client_id and client_secret are auto-generated
)

return application
# Store unhashed client_secret for response
client_secret = application.client_secret

# client_secret is hashed automatically on save
application.save()

return application, client_secret

def _success_response(self, application, token_endpoint_auth_method):
"""Generate successful registration response"""
Expand Down