Skip to content

Use \d #6423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jburel wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Use \d #6423

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d521ea7
Use \d
jburel Mar 13, 2025
d5b6542
use raw string
jburel Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions components/antlib/scripts/parse_version
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ def snapshot_logic(omero_version):

See gh-67 for the discussion.
"""
m = re.match((
re.compile()
Copy link
Member

@sbesson sbesson Jun 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be reverted?

Suggested change
re.compile()

Copy link
Member

@sbesson sbesson Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jburel converted my comment into a suggestion

m = re.match(r(
"^"
"(?P<BASE>.*?)"
"(?P<STRIP>([-]DEV)?-\d+-[a-f0-9]+?(-dirty)?)"
Expand Down Expand Up @@ -115,7 +116,7 @@ def incr_version(omero_version):
omero_version = new_vers
except:
# But if that doesn't work, we brute force with regex
m = re.match("^([^\d]*\d+[.]\d+[.])(\d+)-SNAPSHOT$", omero_version)
m = re.match(r"^([^\d]*\\d+[.]\d+[.])(\d+)-SNAPSHOT$", omero_version)
if m:
next = int(m.group(2)) + 1
omero_version = "%s%s-SNAPSHOT" % (m.group(1), next)
Expand Down
Loading