Skip to content

Change type of csvimport_import.comment to LONGTEXT #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jajm wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Change type of csvimport_import.comment to LONGTEXT #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3b5ffa
Change type of csvimport_import.comment to LONGTEXT
jajm Feb 24, 2026
dab117a
Fix csvimport_import.comment definition in upgrade method
jajm Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Module.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public function install(ServiceLocatorInterface $serviceLocator)
id INT AUTO_INCREMENT NOT NULL,
job_id INT NOT NULL,
undo_job_id INT DEFAULT NULL,
comment VARCHAR(255) DEFAULT NULL,
comment LONGTEXT DEFAULT NULL,
resource_type VARCHAR(255) NOT NULL,
has_err TINYINT(1) NOT NULL,
stats LONGTEXT NOT NULL COMMENT '(DC2Type:json_array)',
Expand Down Expand Up @@ -70,8 +70,9 @@ public function uninstall(ServiceLocatorInterface $serviceLocator)

public function upgrade($oldVersion, $newVersion, ServiceLocatorInterface $serviceLocator)
{
$connection = $serviceLocator->get('Omeka\Connection');

if (version_compare($oldVersion, '1.1.1-rc.1', '<')) {
$connection = $serviceLocator->get('Omeka\Connection');
$sql = <<<'SQL'
ALTER TABLE csvimport_import ADD stats LONGTEXT NOT NULL COMMENT '(DC2Type:json_array)';
UPDATE csvimport_import SET stats = CONCAT('{"processed":{"', resource_type, '":', added_count, '}}');
Expand All @@ -82,5 +83,9 @@ public function upgrade($oldVersion, $newVersion, ServiceLocatorInterface $servi
$connection->exec($sql);
}
}

if (version_compare($oldVersion, '2.6.3', '<')) {
$connection->executeStatement('ALTER TABLE csvimport_import MODIFY comment LONGTEXT DEFAULT NULL');
}
}
}
2 changes: 1 addition & 1 deletion config/module.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ author_link = "https://omeka.org/"
module_link = "https://omeka.org/s/docs/user-manual/modules/csvimport/"
support_link = "https://forum.omeka.org/c/omeka-s/modules"
configurable = false
version = "2.6.2"
version = "2.6.3"
omeka_version_constraint = "^4.0.0"
2 changes: 1 addition & 1 deletion src/Entity/CSVImportImport.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class CSVImportImport extends AbstractEntity
protected $undoJob;

/**
* @Column(type="string", nullable=true)
* @Column(type="text", nullable=true)
*/
protected $comment;

Expand Down