Fix a flaky test by cleaning a polluted state. #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR is to fix a flaky test
cynergy/tests/test_register_multiple.py::test_register_multiple, which can fail after runningcynergy/tests/test_register_multiple.py::test_multiple_list_arguments_with_wrap, but passes when it is run in isolation.Reproduce the test failure
Run the following command:
Expected result
Test
cynergy/tests/test_register_multiple.py::test_register_multipleshould pass when it is run after testcynergy/tests/test_register_multiple.py::test_multiple_list_arguments_with_wrapActual result
Test
cynergy/tests/test_register_multiple.py::test_register_multiplefails:Why it fails:
After running
cynergy/tests/test_register_multiple.py::test_multiple_list_arguments_with_wrap, thecontaineris polluted.Fix:
Clear container each time before
cynergy/tests/test_register_multiple.py::test_register_multipleruns.