Skip to content

[MIT-3593] Sunset Internet Banking#181

Merged
rosle merged 2 commits intomasterfrom
MIT-3593-sunset-internet-banking
Mar 24, 2026
Merged

[MIT-3593] Sunset Internet Banking#181
rosle merged 2 commits intomasterfrom
MIT-3593-sunset-internet-banking

Conversation

@rosle
Copy link
Copy Markdown
Contributor

@rosle rosle commented Mar 13, 2026

Description

Sunset Internet banking:

  • Updated the test fixtures.
  • Adjusted the package tags.

Related links:

Rollback procedure

default rollback procedure

@rosle rosle self-assigned this Mar 13, 2026
@rosle rosle requested a review from Copilot March 13, 2026 08:11
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates test fixtures and Composer package metadata to reflect the sunsetting of Internet Banking payment methods (per MIT-3593), ensuring local/CI tests align with the current API surface.

Changes:

  • Refreshed the /charges fixture data (including removal of any internet banking-related charge/source representations).
  • Removed internet_banking_bay and internet_banking_bbl from the /capability payment methods fixture.
  • Adjusted Composer package keywords/tags to drop “internet banking payment” (and other removed keywords).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tests/fixtures/api.omise.co/charges-get.json Updates the mocked /charges list response to match current API data and remove internet banking-related content.
tests/fixtures/api.omise.co/capability-get.json Removes internet banking payment methods from the capability fixture’s payment_methods list.
composer.json Updates package keywords to align with the sunset and revised tagging.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@rosle rosle marked this pull request as ready for review March 16, 2026 03:29
@rosle rosle merged commit cd519a5 into master Mar 24, 2026
16 checks passed
@rosle rosle deleted the MIT-3593-sunset-internet-banking branch March 24, 2026 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants