Add issue descriptions for struct support with attribute access#3
Draft
Add issue descriptions for struct support with attribute access#3
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Copilot
AI
changed the title
[WIP] Analyze repository for struct definitions and attribute access
Add issue description for struct support with attribute access
Nov 30, 2025
Owner
|
@copilot yes please |
Co-authored-by: omsherikar <180152315+omsherikar@users.noreply.github.com>
Author
Owner
|
@copilot I want like seperate issues and its description not in 1 issue only |
Co-authored-by: omsherikar <180152315+omsherikar@users.noreply.github.com>
Author
Split into 6 separate issue files in
Each file contains the issue title, description, tasks, example code, and acceptance criteria. |
Copilot
AI
changed the title
Add issue description for struct support with attribute access
Add issue descriptions for struct support with attribute access
Nov 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
you work. When you're ready for a review, change the status to Ready for
review to trigger a new review round. If you make additional changes and
don't want to trigger the bot, switch the PR back to Draft.
share your feedback; it helps us improve the tool.
as possible to increase the chances of a timely review. Large PRs may not be
reviewed and may be closed.
self-documenting
(guidance).
our Discord to discuss ideas, blockers, or issues
(https://discord.gg/Nu4MdGj9jB).
sensitive data/PII in code, configs, logs, screenshots, or commit history. If
something leaks, rotate the credentials immediately, invalidate the old key,
and note it in the PR so maintainers can assist.
needed for tests, prefer small fixtures or programmatic downloads declared in
makim.yaml (e.g., a task that fetches data at test time). If a large binary is
unavoidable, discuss first and consider Git LFS.
Pull Request description
Analysis and issue proposals for adding struct support to IRx, inspired by LLVM's CodeGenTypes.cpp#L792.
Key findings:
astxalready providesStructDefStmt/StructDeclStmtbut IRx lacks LLVM IR codegenIdentifiedStructType+ GEP for struct field accessAdded 6 separate issue proposal documents in
docs/proposals/:phase1-struct-type-definition.md- TranslateStructDefStmt→ LLVMIdentifiedStructTypephase2-struct-type-reference.md- NewStructTypeclass for variable declarationsphase3-struct-instantiation.md- NewStructExprwith field initializersphase4-attribute-access-read.md- NewAttributeExprusing GEP + loadphase5-attribute-assignment-write.md- NewAttributeAssignmentusing GEP + storephase6-testing-documentation.md- Comprehensive tests and documentationTarget LLVM IR pattern:
Files to modify:
src/irx/system.py,src/irx/builders/llvmliteir.pyEach issue document contains:
How to test these changes
docs/proposals/Pull Request checklists
This PR is a:
About this PR:
Author's checklist:
complexity.
Additional information
This PR adds 6 separate issue proposal documents in
docs/proposals/, each containing a complete issue title and implementation plan for one phase of struct support. The documents can be used directly to create separate GitHub issues for tracking the implementation work.Reviewer's checklist
Copy and paste this template for your review's note:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.