Conversation
- Generated 549 comprehensive tests across 3 apps - apps/share: 123 tests (100% coverage) - Unit tests for types and validations - apps/server: 336 tests (100% coverage) - API/Integration tests with Hono testClient - apps/client: 90 tests (100% coverage) - Vue component tests with @vue/test-utils - Added test patterns documentation for each app tier - All tests pass without failures Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
- Keep tsconfig.json for production (no bun types) - Create tsconfig.test.json for test files with bun types - apps/server, apps/client, apps/share: all have separate configs - Prevents accidental bun:test usage in production code Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This commit replaces Oxfmt/Oxlint with knip for code quality enforcement. Updates ignoreFiles in knip.json to exclude test directories for more accurate linting.
- Use setup-bun with version specified - Cron daily at midnight for weekly package updates - Automated commit and PR created on update-weekly branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive test coverage strategy for the monorepo, focusing on achieving 100% coverage using
bun:testacross all app packages (share,server, andclient). It adds detailed testing guides and patterns for each app type, updates documentation to reflect the switch tobun:test, and introduces new GitHub Actions workflows for CI and weekly dependency updates.Test strategy and documentation:
.agents/plans/bun-test/PLAN.mdoutlining a workflow for achieving 100% test coverage withbun:test, including file structure mirroring, configuration, and coverage strategies.apps/share: Unit testing schemas, pure functions, and classes with Arktype, including coverage checklists.apps/server: API, middleware, and webhook testing withhono/testing, mocking strategies, and coverage checklists.apps/client: Vue component and composable testing with@vue/test-utils, including setup, mocking, and coverage checklists.apps/AGENTS.mdto reflect the adoption ofbun:testfor all app packages, specifying test types and tools per app.Tooling and workflow improvements:
@types/buntoapps/client/package.jsonto support Bun-specific typings for testing..github/workflows/ci.yml: CI workflow running install, lint, format, knip, and build steps with Bun..github/workflows/weekly-update.yml: Scheduled workflow to update dependencies weekly and create a PR automatically.