Skip to content

redesign signin & loading view#241

Merged
HALQME merged 3 commits intomainfrom
auth
Apr 12, 2026
Merged

redesign signin & loading view#241
HALQME merged 3 commits intomainfrom
auth

Conversation

@HALQME
Copy link
Copy Markdown
Contributor

@HALQME HALQME commented Apr 12, 2026

This pull request introduces several UI improvements and code refactoring for the sign-in flow and profile components. The main changes include extracting a new LoadingView component for a cleaner sign-in experience, updating icon usage for consistency, improving the display of usernames, and minor backend logic adjustments.

Sign-in Flow Refactor and UI Enhancement:

  • Extracted a new LoadingView component for the sign-in redirect/loading state, simplifying SignIn.vue and improving code reusability. The new component provides a spinner and a fallback link if redirection fails (LoadingView.vue, SignIn.vue) [1] [2] [3].
  • Removed the progress bar and refactored the loading state logic in SignIn.vue for a cleaner UI and better separation of concerns (SignIn.vue) [1] [2].

Icon and Visual Improvements:

  • Replaced usage of imported icon components with Lucide icon classes (e.g., i-lucide:chevrons-up-down, i-lucide:check) in ProfileCard.vue for grade/year dropdowns, improving icon consistency and reducing bundle size (ProfileCard.vue) [1] [2] [3] [4].
  • Updated styling for selected dropdown options to highlight them in blue and improved layout for better accessibility and clarity (ProfileCard.vue) [1] [2].

Profile Display Improvements:

  • Updated the username display in UserHeader.vue to always show an @ prefix if a username exists, improving clarity and consistency (UserHeader.vue).

Backend Adjustment:

  • Modified the user update handler to explicitly set username to an empty string if not provided, ensuring correct backend behavior when clearing the username (clerk.ts).

@HALQME HALQME merged commit 58c2291 into main Apr 12, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant