Fix issue with Folium v0.15.0 re. adding layers to map#3
Open
Conengmo wants to merge 1 commit intoonaci:mainfrom
Open
Fix issue with Folium v0.15.0 re. adding layers to map#3Conengmo wants to merge 1 commit intoonaci:mainfrom
Conengmo wants to merge 1 commit intoonaci:mainfrom
Conversation
Author
|
@danwild I wanted to bring this PR to your attention, if you have a moment it would be great if you could check it out. This plugin is currently broken with newer Folium versions and this should fix it. I understand if you're busy though :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Folium v0.15.0 we added a change in how layers are added to the map. This broke things here in this plugin. See python-visualization/folium#1690.
Fix it by not adding the layer to the map on initialization, but let the Layer class take care of that.
In addition, I opted to put the logic in a function so variable names like
mapandoptionsdon't interfere with other scopes.