Use configured youtube folder for downloading #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The download routine had the target folder hardcoded to "_youtube", not respecting the ytPath variable in conf.ts. Fix this by propagating the configured folder to the downloader. Limit it to a single, non-relative, folder for safety.
gaaf
force-pushed
the
use-configured-ytpath
branch
from
5675945 to
5e7d738
Compare
Owner
|
I am currently on a vacation until the end of August. Acknowledging the issue, will look into it when I come back. As far as I remember, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The download routine had the target folder hardcoded to "_youtube", not respecting the ytPath variable in conf.ts.
Fix this by propagating the configured folder to the downloader.
Limit it to a single, non-relative, folder for safety. Probably still not very secure, but as I know next to nothing about nodejs, I saw no other means to respect the ytPath variable.